This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Fixed wrong ring_width calculation in Radial Average #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It depended on the order of the elements of the kx and ky 2d arrays.
leouieda
suggested changes
Nov 18, 2017
| @@ -591,7 +591,8 @@ def radial_average_spectrum(kx, ky, pds, max_radius=None, ring_width=None): | |||
| if max_radius is None: | |||
| max_radius = min(kx.max(), ky.max()) | |||
| if ring_width is None: | |||
| ring_width = max(kx[1, 0], ky[0, 1]) | |||
| ring_width = max(numpy.unique(kx)[numpy.unique(kx) > 0][0], | |||
| numpy.unique(ky)[numpy.unique(ky) > 0][0]) | |||
There was a problem hiding this comment.
@santis19 thanks for the fix! I just noticed that the docstring is wrong. It describes data and shape when the function receives pds. Would you mind fixing this as well? Let me know and I'll merge the PR.
There was a problem hiding this comment.
@leouieda, thanks for noticing it, it seems that I was more aware of the code than the documentation.
Now it's fixed. If you like how the new documentation is written, merge it!
leouieda
approved these changes
Nov 22, 2017
|
Merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code computed the
ring_widthassuming that the elements of thekxandky2d arrays where ordered in a special way: thekyvary first.This is not always true, mainly due to how we define the
x,yarrays that we use to compute thekxandky.Now the code works independently how those arrays are ordered.
Checklist:
doc/install.rst,environment.yml,ci/requirements.txt.cd doc; makelocally)doc/contributors.rst(leave for last to avoid conflicts)