This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Implement regression tests for gravmag.polyprism #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were many different functions and weren't using numpy.testing. This decreases test coverage because I don't test Cython vs numpy so the numpy code goes untested.
Include the data generation function in the test file and use pytest fixtures to pass in the data to the test.
leouieda
added a commit
that referenced
this pull request
May 5, 2017
Use the standard from #395 to implement the sphere regression tests. Include code to generate the test data in the tests so they can be updated if needed.
leouieda
added a commit
that referenced
this pull request
May 5, 2017
Use the standard from #395 to implement the sphere regression tests. Include code to generate the test data in the tests so they can be updated if needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the tests of
polyprismvsprismand add regression tests against savedresults, like was done for
spherein #364.This allows us to test more complex polygonal prisms (an ellipse for example) and
catch regressions that might affect both
polyprismandprismat the same time.Test coverage decreases because the numpy alternative implementation is not
tested anymore. This will become the main version in #368 so it's not a big deal
right now.
Checklist:
doc/install.rst,environment.yml,ci/requirements.txt.cd doc; makelocally)