This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Finite-difference wave modeling with an object-oriented API (2nd attempt) #308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
This is a retry at PR #137. I'll start fresh and take the best code and lessons learned from that PR to make this.
Defines a new API for the
fatiando.seismic.wavefd
module. You now interact with simulation classes instead of generator functions. The simulation data that was thrown away before is now kept in an HDF5 file. This adds the dependency ofh5py
but it's worth it. The class also knows how to produce an animation of the simulation. The video animation can be embedded into the Jupyter notebook.As an added bonus, replaces the Cython time-stepping functions with numba equivalents without loss
in speed.
TODO
Checklist:
doc/install.rst
,requirements.txt
,environment.yml
,ci/requirements-conda.txt
andci/requirements-pip.txt
.cd doc; make
locally)