Ditch kernel functions for point masses #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel functions for gravity fields of point sources were just one line functions with a lot of docstrings and their own tests. We are not using them outsides the actual gravity forward modelling functions for point masses, so it might be better to remove them. We can always restore them if we find a use case for them.
|
Weeeeeell turns out we needed this for dipole inversions in https://github.com/compgeolab/micromag-euler-dipole/blob/main/code/micromag.py#L284 🤦🏾 Should we add this back (tests will be covered by the gravity tests) or use the gravity functions divided by G? |
|
Haha, if they were useful, we can get them back. The only reason to remove them was that we didn't thought a use case for them. Would you like to open a PR that reverts this PR? I'll be glad if the tests are simpler. |
santisoler
added a commit
that referenced
this pull request
Aug 17, 2023
This reverts commit 655305a.
leouieda
pushed a commit
that referenced
this pull request
Feb 20, 2024
Revert "Ditch kernel functions for point masses (#42)". Remove tests for point source kernels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel functions for gravity fields of point sources were just one line functions with a lot of docstrings and their own tests. We are not using them outsides the actual gravity forward modelling functions for point masses, so it might be better to remove them. We can always restore them if we find a use case for them.
Relevant issues/PRs:
Fixes #38