Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch the kernels functions for point masses #38

Closed
santisoler opened this issue Apr 19, 2023 · 0 comments · Fixed by #42
Closed

Ditch the kernels functions for point masses #38

santisoler opened this issue Apr 19, 2023 · 0 comments · Fixed by #42
Labels
maintenance A maintenance task to improve development

Comments

@santisoler
Copy link
Member

The forward modelling functions for point masses make use of kernel functions for each field. These functions executes just a single line and they are mostly repeated documentation. Besides, we don't expect using those functions outside the forward modelling of point sources in cartesian coordinates, so we could simplify the API by removing those and include their code in the forward modelling functions.

Worth noting that for the spherical coordinates forward modelling functions we want those kernels so they can be used for forward modelling tesseroids (check harmonica.tesseroid_gravity).

@santisoler santisoler added the maintenance A maintenance task to improve development label Apr 19, 2023
santisoler added a commit that referenced this issue Apr 25, 2023
The kernel functions for gravity fields of point sources were just one
line functions with a lot of docstrings and their own tests. We are not
using them outsides the actual gravity forward modelling functions for
point masses, so it might be better to remove them. We can always
restore them if we find a use case for them.

**Relevant issues/PRs:**

Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance A maintenance task to improve development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant