Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return nan when computing magnetic field inside a prism #36

Closed
santisoler opened this issue Feb 10, 2023 · 0 comments · Fixed by #30
Closed

Return nan when computing magnetic field inside a prism #36

santisoler opened this issue Feb 10, 2023 · 0 comments · Fixed by #30
Labels
enhancement Idea or request for a new feature

Comments

@santisoler
Copy link
Member

Description of the desired feature:

Inline with #30, the magnetic forward modelling functions for prism should return nan on the same singular points of the gravity tensor components, but also for any point inside the prism, since the magnetic field we compute is obtained after assuming we are outside of sources.

Are you willing to help implement and maintain this feature?

Sure!
@santisoler santisoler added the enhancement Idea or request for a new feature label Feb 10, 2023
@santisoler santisoler mentioned this issue Apr 20, 2023
Merged
santisoler added a commit that referenced this issue Apr 26, 2023
@santisoler
Prism forward models return nan on singular points (#30)
de9ba39 
Gravity and magnetic forward modelling functions for prisms return
`np.nan` when the observation points falls in a singular point. These
singular points vary for the field that is being computed. For the
gravity tensor components, these are all the vertices and edges
perpendicular to the direction(s) of the tensor component. For the
magnetic fields, these are all the vertices, all the edges and all the
interior points. This PR also fixes the values of the fields on the
faces: diagonal gravity tensor components and magnetic field components
on prism faces return the limit of the field approaching from outside.
To achieve that, a 4π constant must be added when computing on the east,
north or top faces. Add tests for these new features and include
explanations in the docstrings.

**Relevant issues**

Fixes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Idea or request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prism forward models return nan on singular points fatiando/choclo
1 participant
@santisoler