Fix the problem of long connection for more than 30 seconds and disconnection of the server #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'd better not use chinese in commit log, it's not friendly for others. |
fatedier
requested changes
Aug 6, 2018
cmd/frps/root.go
Outdated
| allowPorts string | ||
| maxPoolCount int64 | ||
| maxPortsPerClient int64 | ||
| ResponseHeaderTimeout int64 |
There was a problem hiding this comment.
Use lowercase letter at the beginning and the word ResponseHeaderTimeout is not clear for others to figure out where it's used.
vhost_http_timeout is better.
There was a problem hiding this comment.
OK, I've changed it
cmd/frps/root.go
Outdated
| @@ -85,6 +86,7 @@ func init() { | |||
| rootCmd.PersistentFlags().Int64VarP(&authTimeout, "auth_timeout", "", 900, "auth timeout") | |||
| rootCmd.PersistentFlags().StringVarP(&subDomainHost, "subdomain_host", "", "", "subdomain host") | |||
| rootCmd.PersistentFlags().Int64VarP(&maxPortsPerClient, "max_ports_per_client", "", 0, "max ports per client") | |||
| rootCmd.PersistentFlags().Int64VarP(&ResponseHeaderTimeout, "Response_Header_Timeout", "", 30, "Response Header Timeout") | |||
There was a problem hiding this comment.
OK, I've changed it
conf/frps_full.ini
Outdated
| @@ -66,3 +66,6 @@ subdomain_host = frps.com | |||
|
|
|||
| # if tcp stream multiplexing is used, default is true | |||
| tcp_mux = true | |||
|
|
|||
| # if Response Header Timeout more the 30s ,fix the pars . | |||
| ResponseHeaderTimeout = 30 | |||
There was a problem hiding this comment.
Use lowercase letters and underline.
There was a problem hiding this comment.
OK, I've changed it
… and Use lowercase letter at the beginning
|
Please rebase all commit log into one without chinese. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem of long connection for more than 30 seconds and disconnection of the server
#770