fix(service/create): input.Type assigned wrong value #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot create a service with a comment, or change type of service creation due to bug.
Integralist
approved these changes
Mar 20, 2023
|
👋🏻 Thanks @mdlutz24 for opening this PR! Very much appreciated 🙂 I'l merge this once the CI checks are all passing 👍🏻 |
|
Thanks! I found this trying to figure out why I was getting a "Type must be vcl etc" error when I was explicitly setting type to vcl, and saw what looked like an obvious typo/copypasta. Threw up the pr quickly, just to document it, and intending to follow up with an issue, but I'm really happy to see it was acted on so quickly. :-) |
|
Thanks @mdlutz24 you'll find these fix has been released as part of the 8.1.2 patch release: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot create a service with a comment, or change type of service creation due to bug.