Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds --cert-path argument to tls-custom certificate update command to pass in a path to a certificate file #1214

Merged

Conversation

rdoherty-fastly
Copy link
Contributor

Adds --cert-path argument to tls-custom certificate update command to pass in a path to a certificate file
Previously users were required to pass in the full certificate contents via the --cert-blob argument, which is cumbersome and error-prone. This allows users to specify a path to a certificate making this command easier to use.

The new argument --cert-path is mutually exclusive with --cert-blob and the command will return an error if both are specified.

This is a near duplicate of #1189 except for the update command vs create

@Integralist Integralist added the enhancement New feature or request label May 30, 2024
…o pass in a path to a certificate file

Previously users were required to pass in the full certificate contents via the --cert-blob argument, which is cumbersome and error-prone. This allows users to specify a path to a certificate making this command easier to use.

The new argument --cert-path is mutually exclusive with --cert-blob and the command will return an error if both are specified.
@Integralist
Copy link
Collaborator

Feel free to merge whenever you're ready

@rdoherty-fastly
Copy link
Contributor Author

im_ready_game_of_thrones

@rdoherty-fastly rdoherty-fastly merged commit 5f014e9 into fastly:main May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants