Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane sh with log set to false should respect a step name #22151

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

mollyIV
Copy link
Member

@mollyIV mollyIV commented Jul 20, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Description

Fastlane sh with log set to false should respect a step name.

Testing Steps

The lane:

sh("ls", log: false, step_name: "list files")

Before 😭

Screenshot 2024-07-20 at 12 35 42

After 🎉

Screenshot 2024-07-20 at 12 35 31

@mollyIV
Copy link
Member Author

mollyIV commented Jul 20, 2024

The error seems to be unrelated to the changes introduced in this PR. Can somebody from fastlane team help here please? 🙏

RubyGems system software updated
Fetching bundler-2.3.21.gem
ERROR:  While executing gem ... (Gem::FilePermissionError)
    You don't have write permissions for the /Users/distiller/.rbenv/versions/3.2.2/bin/bundle.lock directory.

@mollyIV
Copy link
Member Author

mollyIV commented Jul 24, 2024

FYI, the CI tests failures have been resolved by pulling the fixes from the main branch.

Copy link
Collaborator

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@giginet
Copy link
Collaborator

giginet commented Jul 26, 2024

Running AppVeyor job is flaky. It may be fixed with a rerun. However, I don't have permission to execute the job 🤷

@mollyIV mollyIV merged commit ac23bcd into master Jul 26, 2024
7 checks passed
@mollyIV mollyIV deleted the sh-log-false-step-name branch July 26, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants