types: add FastifyJwtNamespace helper #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fdawgs
requested changes
Aug 10, 2023
Co-authored-by: Frazer Smith <[email protected]>
|
Thanks |
climba03003
reviewed
Aug 10, 2023
| secretFnBufferCallback: (_req, _token, cb) => { cb(null, Buffer.from('some secret', 'base64')) }, | ||
| secretFnBufferPromise: (_req, _token) => Promise.resolve(Buffer.from('some secret', 'base64')), | ||
| secretFnBufferAsync: async (_req, _token) => Buffer.from('some secret', 'base64'), | ||
| secretFnCallback: (_req: any, _token: any, cb: any) => { cb(null, 'supersecret') }, |
There was a problem hiding this comment.
Shouldn't the function arguments should infer the correct types here?
Providing :any seems to be breaking changes.
We may type the const as Record<string, FastifyJWTOptions['secret']
There was a problem hiding this comment.
We have again issues with determining the right function type
|
I somehow think that all plugins which use namespaces or custom defined values should have something like this helper interface. I am currently thinking, if instead of having four generics, to have one generic and use that for the interface. Interface would be then identical to the option. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct