Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version 6.1.0 instead 6.0.0 #241

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Use version 6.1.0 instead 6.0.0 #241

merged 1 commit into from
Mar 8, 2024

Conversation

carlosal1015
Copy link
Contributor

Hi there, I would like to ask if is possible to update version in order to sent this patch to downstream because if this digits are different generates issues, for example for https://aur.archlinux.org/packages/ants#comment-960051 or any project that has find_package(VTK) and has fast_float-6.1.0.

@lemire lemire merged commit 2f3ed44 into fastfloat:main Mar 8, 2024
@lemire
Copy link
Member

lemire commented Mar 8, 2024

Thanks. I have retagged the release with this fix.

robomics added a commit to robomics/fast_float-feedstock that referenced this pull request Mar 8, 2024
robomics added a commit to robomics/conan-center-index that referenced this pull request Mar 8, 2024
@ptrcnull
Copy link

ptrcnull commented Mar 8, 2024

hiya, just wanted to let you know that retagging releases causes issues for downstream distribution maintainers ( for example, see https://gitlab.archlinux.org/archlinux/packaging/packages/fast_float/-/issues/1 ) - changing a tag changes the tarball, which then makes all builds fail because of checksum mismatches 😅

in this case, bumping the patch version would have probably been a better choice

@lemire
Copy link
Member

lemire commented Mar 8, 2024

@carlosal1015 @ptrcnull

I literally I cannot update the version without changing the tar ball and the checksum. This is not possible. Sorry.

There is just no perfect solution. Sorry.

I am not sure why the CMake version wasn't updated. I'll make sure to fix the process in the future.

@ptrcnull
Copy link

ptrcnull commented Mar 8, 2024

then just.. keep the 6.1.0 tag with the CMake version mismatch? when you have a bug, you don't fix it by amending the release, you fix it by cutting a new one :p

@nekopsykose
Copy link

I literally I cannot update the version without changing the tar ball and the checksum.

the request wasn't to update the same version and not change the tarball (which is logically impossible indeed), but to just make a new version, like v6.1.1. natural numbers are free, after all

@lemire
Copy link
Member

lemire commented Mar 8, 2024

the request wasn't to update the same version

Please see above. @carlosal1015 requested that we update the version, it was not to issue a new version. Please see screenshot of the comment above. Please review the PR changes.

Screenshot 2024-03-08 at 6 16 22 PM

I am making sure that this issue does not occur again in the future.

For the time being, this issue is closed.

natural numbers are free, after all

Please see my comment above: there is no perfect solution in such cases.

@fastfloat fastfloat locked as resolved and limited conversation to collaborators Mar 8, 2024
@carlosal1015 carlosal1015 deleted the fix/version-numbering branch March 9, 2024 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants