Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using updated brands, portals and endpoints catalog #22

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

AnalogJ
Copy link
Member

@AnalogJ AnalogJ commented Jan 17, 2024

No description provided.

…ndpoints that are generated by fasten-sources-gen.
Adding tests to ensure all catalog endpoints have a valid/known platform.
update SourceCredential interaface with additional GetEndpoint/Brand/Portal methods.
@codecov-commenter
Copy link

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (28e9ddc) 17.96% compared to head (606081b) 48.19%.

Files Patch % Lines
catalog/catalog.go 43.06% 105 Missing and 14 partials ⚠️
definitions/factory.go 30.30% 44 Missing and 2 partials ⚠️
clients/internal/dynamic_client.go 63.04% 13 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #22       +/-   ##
===========================================
+ Coverage   17.96%   48.19%   +30.22%     
===========================================
  Files          26        7       -19     
  Lines        2661      664     -1997     
===========================================
- Hits          478      320      -158     
+ Misses       2101      305     -1796     
+ Partials       82       39       -43     
Flag Coverage Δ
unittests 48.19% <43.47%> (+30.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnalogJ AnalogJ merged commit 65e6980 into main Jan 17, 2024
3 of 5 checks passed
@AnalogJ AnalogJ deleted the fasten_sources_embedded_json branch January 17, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants