Prevent possible endless loop with image fallback

[jean-the-coder]

Description

So I noticed that in the Storybook upload off of main that the medical sources card component is erroring out and it isn't able to generate snapshots. When I click into it on the website it seems like there are two problems:

1. The assets aren't getting added to the storybook upload causing the fallback image not to be found.
2. The image fallback directive is trapped in an endless loop looking for the fallback image.

I found some docs saying that serving static assets via Storybook configuration is recommended so I've tried adding that configuration. I'm not sure if it will work, or if this is what is causing the component error making the build fail, but I figured it was worth a shot.

As for the second issue, I've updated the image fallback code so that it shouldn't endlessly loop in the case that even the fallback image fails. Basically it just checks to see if the failed image was the fallback image and if it was, return rather than resetting src which triggers another attempt and error and so on.

Changes

• add config to storybook for serving static assets
• only attempt to load fallback image if we haven't already tried to load it

[AnalogJ]

wow, this is a 🤦 moment for me. Great catch.