- make sure that we can generate offline tokens for Epic providers (u… #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing dynamic client registration - https://fhir.epic.com/Documentation?docId=Oauth2§ion=Standalone-Oauth2-OfflineAccess-0) - when SourceCredential is sent to the CreateSource API, we'll check if dynamic client regirstion is enabled. If it is, we'll use this token to register a new client, store the client information, and geneate a new Access Token using the key pair associated with this newly registered client. - added additional fields to SourceCredential table (registration_endpoint, dynamic_client_registration_mode, dynamic_client_jwks, dynamic_client_id) - renamed RefreshTokens to SetTokens in SourceCredential model - to have consistent naming - added IsDynamicClient and RefreshDynamicClientAccessToken methods to SourceCredential Model fixes #178
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| "client_id": {s.DynamicClientId}, | ||
| } | ||
|
|
||
| tokenResp, err := http.PostForm(s.TokenEndpoint, postForm) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request Critical
| req.Header.Set("Accept", "application/json") | ||
| req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", sourceCred.AccessToken)) | ||
|
|
||
| registrationResponse, err := http.DefaultClient.Do(req) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request Critical
Added an update source method. After sync, if sourcecredential access token/refresh token has been updated make sure we store it int he database.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
========================================
+ Coverage 9.71% 9.74% +0.02%
========================================
Files 221 222 +1
Lines 27017 27244 +227
Branches 450 450
========================================
+ Hits 2625 2654 +29
- Misses 24255 24446 +191
- Partials 137 144 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing dynamic client registration - https://fhir.epic.com/Documentation?docId=Oauth2§ion=Standalone-Oauth2-OfflineAccess-0)
fixes #178
TODO: