started working on DICOM support (stored in Media object) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnalogJ
commented
Mar 24, 2023
Comment on lines
143
to
149
| //TODO: THIS IS BROKEN. FIX IT | ||
| let files = [new File([ | ||
| new Blob([this.displayModel.content]) | ||
| ], "dicom.dcm", {type: "application/dicom"})] | ||
| console.log("LOADED FILE FROM RESOURCE", files) | ||
|
|
||
| this.dwvApp.loadFiles(files); |
There was a problem hiding this comment.
TODO: we need to figure out why this is broken.
AnalogJ
commented
Mar 24, 2023
Comment on lines
297
to
303
| onFileChange(event) { | ||
| //TODO: This works correctly, but it's not the right way to do it (we should load from resource) | ||
| console.log("onFileChange"); | ||
| console.log(event); | ||
| console.log(event.target.files); | ||
| this.dwvApp.loadFiles(event.target.files); | ||
| } |
There was a problem hiding this comment.
TODO: this works, but we need to remove it.
…ur graph generation is heavyweight
…hen generating graph.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39
dicom_viewer_0012.zip
test file attached to this PR - extract it first.
The relevant files that my be broken are here:
DICOM display component
Resource Base64 decoding
DICOM file uploading (via Form)
instructions
Categoryshould beDiagnostic imaging studyFile Typeshould beImage - DICOM