Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(*): apply some lint suggestions #474

Merged
merged 3 commits into from
Jul 18, 2023
Merged

style(*): apply some lint suggestions #474

merged 3 commits into from
Jul 18, 2023

Conversation

siyou
Copy link
Member

@siyou siyou commented Jul 16, 2023

Description:

BREAKING CHANGE:

Related issue (if exists):

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2023

⚠️ No Changeset found

Latest commit: eeb033d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wre232114
Copy link
Member

thanks!

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #474 (ce4d030) into main (f2abaa7) will increase coverage by 0.10%.
The diff coverage is 83.65%.

❗ Current head ce4d030 differs from pull request most recent head eeb033d. Consider uploading reports for the commit eeb033d to get more accurate results

@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   80.43%   80.54%   +0.10%     
==========================================
  Files         130      130              
  Lines       16144    16090      -54     
==========================================
- Hits        12986    12959      -27     
+ Misses       3158     3131      -27     
Impacted Files Coverage Δ
crates/node/src/lib.rs 0.38% <ø> (ø)
crates/plugin_lazy_compilation/src/lib.rs 0.76% <0.00%> (ø)
crates/plugin_polyfill/src/lib.rs 1.01% <0.00%> (ø)
crates/plugin_resolve/tests/imports.rs 97.00% <ø> (ø)
...rates/plugin_runtime/src/insert_runtime_plugins.rs 78.37% <0.00%> (ø)
crates/plugin_script/src/swc_plugins.rs 1.94% <0.00%> (ø)
crates/plugin_static_assets/src/lib.rs 15.45% <0.00%> (ø)
crates/toolkit/src/resolve/symlinks_analyzer.rs 75.00% <0.00%> (+7.35%) ⬆️
crates/plugin_css/src/transform_resource_pot.rs 91.11% <50.00%> (ø)
crates/plugin_html/src/utils.rs 96.87% <50.00%> (+7.98%) ⬆️
... and 37 more

... and 6 files with indirect coverage changes

@siyou siyou requested a review from wre232114 July 18, 2023 13:38
@wre232114 wre232114 enabled auto-merge (squash) July 18, 2023 15:05
@wre232114 wre232114 merged commit e73130b into farm-fe:main Jul 18, 2023
26 checks passed
@siyou siyou deleted the style/clippy branch July 27, 2023 14:30
This was referenced Mar 11, 2024
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants