Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolve): support resolver other dependencies by alias #198

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

ErKeLost
Copy link
Member

@ErKeLost ErKeLost commented Apr 12, 2023

Description:

resolver support Import other dependencies by alias

// package.json
{
  "imports": {
    "#dep": {
      "node": "dep-node-native",
      "default": "./dep-polyfill.js"
    }
  },
  "dependencies": {
    "dep-node-native": "^1.0.0"
  }
}

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

⚠️ No Changeset found

Latest commit: e1289fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ErKeLost ErKeLost changed the title feat(resolve): resolver support import alias deps feat(resolve): support resolver import alias deps Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #198 (e1289fd) into main (eda9d6e) will increase coverage by 28.41%.
The diff coverage is 90.94%.

@@             Coverage Diff             @@
##             main     #198       +/-   ##
===========================================
+ Coverage   50.39%   78.80%   +28.41%     
===========================================
  Files          87      103       +16     
  Lines        4602     6444     +1842     
===========================================
+ Hits         2319     5078     +2759     
+ Misses       2283     1366      -917     
Impacted Files Coverage Δ
crates/compiler/src/update/mod.rs 0.00% <0.00%> (ø)
crates/compiler/src/update/update_context.rs 0.00% <0.00%> (ø)
crates/core/src/config/mod.rs 65.95% <ø> (ø)
crates/core/src/module/module_graph.rs 78.15% <0.00%> (+0.51%) ⬆️
crates/plugin_css/src/lib.rs 47.45% <ø> (+47.45%) ⬆️
crates/plugin_html/src/lib.rs 79.05% <ø> (+64.18%) ⬆️
crates/plugin_resolve/src/lib.rs 92.00% <ø> (+92.00%) ⬆️
crates/compiler/src/build/mod.rs 87.42% <36.36%> (+87.42%) ⬆️
crates/plugin_runtime/src/lib.rs 84.02% <42.85%> (+84.02%) ⬆️
rust-plugins/sass/src/lib.rs 63.85% <63.85%> (ø)
... and 26 more

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ErKeLost ErKeLost changed the title feat(resolve): support resolver import alias deps feat(resolve): support resolver other dependencies by alias Apr 12, 2023
@wre232114 wre232114 enabled auto-merge (squash) April 12, 2023 23:27
@wre232114 wre232114 merged commit 5d30c0d into farm-fe:main Apr 12, 2023
This was referenced Mar 11, 2024
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants