Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: solve issues when add dependencies in HMR #194

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Conversation

wre232114
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):
close #193

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

⚠️ No Changeset found

Latest commit: 1c2bdf4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #194 (1c2bdf4) into main (eda9d6e) will increase coverage by 28.32%.
The diff coverage is 90.84%.

@@             Coverage Diff             @@
##             main     #194       +/-   ##
===========================================
+ Coverage   50.39%   78.72%   +28.32%     
===========================================
  Files          87      103       +16     
  Lines        4602     6424     +1822     
===========================================
+ Hits         2319     5057     +2738     
+ Misses       2283     1367      -916     
Impacted Files Coverage Δ
crates/compiler/src/update/mod.rs 0.00% <0.00%> (ø)
crates/compiler/src/update/update_context.rs 0.00% <0.00%> (ø)
crates/core/src/config/mod.rs 65.95% <ø> (ø)
crates/core/src/module/module_graph.rs 78.15% <0.00%> (+0.51%) ⬆️
crates/plugin_css/src/lib.rs 47.45% <ø> (+47.45%) ⬆️
crates/plugin_html/src/lib.rs 79.05% <ø> (+64.18%) ⬆️
crates/plugin_resolve/src/lib.rs 92.00% <ø> (+92.00%) ⬆️
crates/compiler/src/build/mod.rs 87.42% <36.36%> (+87.42%) ⬆️
crates/plugin_runtime/src/lib.rs 84.02% <42.85%> (+84.02%) ⬆️
rust-plugins/sass/src/lib.rs 63.85% <63.85%> (ø)
... and 26 more

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wre232114 wre232114 merged commit 6243f20 into main Apr 12, 2023
@wre232114 wre232114 deleted the fix/complext-hmr branch April 12, 2023 22:54
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
This was referenced Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR failed when add antd in React example
1 participant