Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a React project changes the components of a router, it does not trigger the HMR and requires a manual refresh or restart #857

Closed
sdhushu opened this issue Dec 28, 2023 · 2 comments · Fixed by #898
Assignees
Labels
bug Something isn't working

Comments

@sdhushu
Copy link

sdhushu commented Dec 28, 2023

Steps to reproduce

  1. pnpm create farm
  2. choose react template
  3. add react router
  4. pnpm dev
  5. replace the element of the route

What is expected?

Triggers HMR page changes

What is actually happening?

No HMR triggered, no change on page

System Info

System:
    OS: macOS 13.3
    CPU: (8) arm64 Apple M1
    Memory: 111.61 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.15.1 - /usr/local/bin/node
    Yarn: 1.22.18 - /usr/local/bin/yarn
    npm: 6.14.14 - /usr/local/bin/npm
    pnpm: 7.9.5 - /usr/local/bin/pnpm
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 16.4
  npmPackages:
    @farmfe/core: ^0.14.18 => 0.14.18

Any additional comments?

No response

@wre232114 wre232114 self-assigned this Jan 2, 2024
@wre232114 wre232114 added the bug Something isn't working label Jan 2, 2024
@wre232114
Copy link
Member

Related to #460

wre232114 added a commit that referenced this issue Jan 18, 2024
@wre232114
Copy link
Member

fixed in @farmfe/[email protected]

@github-actions github-actions bot mentioned this issue Feb 6, 2024
This was referenced Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants