[Bug] partialBundling causes an error in the build product #769

niuiic · 2023-11-22T06:55:34Z

Steps to reproduce

git clone https://github.com/niuiic/gallery
pnpm i
pnpm build --filter css-components
pnpm dev --filter website

Open the console.

The output:

In /home/niuiic/Documents/projects/gallery/apps/website/src/view/page/main/Main.tsx

import cssComponents from 'css-components'
console.log(cssComponents)

cssComponents is {}

In /home/niuiic/Documents/projects/gallery/packages/css/farm.config.build.ts
Unset partialBundling, then cssComponents is an array with one item.
enforceResources is set to [{ name: 'wavyUnderline', test: [ 'src/components/wavyUnderline/*' ] }].

import type { UserConfig } from '@farmfe/core'
import dts from '@farmfe/js-plugin-dts'
import { farmRawPlugin, farmSassPlugin } from 'farm-plugins'
import { readdirSync, statSync } from 'fs'
import { join } from 'path'

const chunks: {
  name: string
  test: string[]
}[] = []

const walkDir = (dirPath: string, cb: (filePath: string) => void) => {
  const items = readdirSync(dirPath)
  items.forEach((item) => {
    const itemPath = join(dirPath, item)
    const isDir = statSync(itemPath).isDirectory()
    if (isDir) {
      walkDir(itemPath, cb)
    } else {
      cb(itemPath)
    }
  })
}

const collectChunks = (filePath: string) => {
  if (!filePath.includes('index.ts')) {
    return
  }
  let matchedText = filePath.match(/\/src\/components\/([^\/]+)\/*/)
  if (matchedText) {
    chunks.push({
      name: matchedText[1],
      test: [`src/components/${matchedText[1]}/*`]
    })
  }
}

walkDir(join(process.cwd(), 'src/components'), collectChunks)

const config: UserConfig = {
  compilation: {
    input: {
      index: './src/index.ts'
    },
    output: {
      entryFilename: 'index.mjs',
      targetEnv: 'browser',
      format: 'esm'
    },
    resolve: {
      alias: {
        '@/': join(process.cwd(), 'src')
      }
    },
    minify: true,
    sourcemap: false,
    presetEnv: false,
    lazyCompilation: true
  },
  plugins: [
    farmSassPlugin(),
    farmRawPlugin(),
    dts({
      tsConfigPath: './tsconfig.json'
    })
  ]
}

export default config

What is expected?

The output

What is actually happening?

{}

System Info

System:
    OS: Linux 6.1 Gentoo Linux
    CPU: (16) x64 AMD Ryzen 7 5800H with Radeon Graphics
    Memory: 12.92 GB / 15.59 GB
    Container: Yes
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.1.0 - /run/user/1000/fnm_multishells/11955_1700613217468/bin/node
    npm: 10.2.0 - /run/user/1000/fnm_multishells/11955_1700613217468/bin/npm
    pnpm: 8.10.5 - /run/user/1000/fnm_multishells/11955_1700613217468/bin/pnpm
  npmPackages:
    @farmfe/core: ^0.14.3 => 0.14.3



### Any additional comments?

_No response_

The text was updated successfully, but these errors were encountered:

niuiic · 2023-11-22T06:58:23Z

In /home/niuiic/Documents/projects/gallery/packages/css/src/index.ts

import * as wavyUnderline from './components/wavyUnderline'

interface Component {
  css: string
  html: string
}

export default [wavyUnderline] as Component[]

wre232114 · 2023-11-22T07:41:02Z

use partialBundling.groups instead of enforceResources. enforceResources will ignore dynamic import contraints.

and test should be a regex, for example: src/components/wavyUnderline/.*

niuiic · 2023-11-22T07:43:12Z

works

niuiic · 2023-11-22T07:49:24Z

I made a mistake, it does not work. Setting groups does not split it into chunks.

set enforceResources

set groups

And there is no dynamic import.

Dynamic import is in src/main.ts which is not used when build.

wre232114 · 2023-11-22T07:52:48Z

try set partialBundling.targetMinSize to 0

niuiic · 2023-11-22T07:55:23Z

Set groups and targetMinSize

farm-plugins:build: cache bypass, force executing 106922e0314b13a1
farm-plugins:build:
farm-plugins:build: > [email protected] build /home/niuiic/Documents/projects/gallery/packages/farm-plugins
farm-plugins:build: > farm build
farm-plugins:build:
farm-plugins:build: [ Farm ] Using config file at /home/niuiic/Documents/projects/gallery/packages/farm-plugins/farm.config.ts
farm-plugins:build: [ Farm ] ⚡️ Build completed in 32ms! Resources emitted to dist.
farm-plugins:build: [ FarmDtsPlugin ] ⚡️ Dts Plugin Build completed in 766ms! Resources emitted to dist.
farm-plugins:build: Failed to mark outputs as cached for farm-plugins#build: rpc error: code = Unavailable desc = cookie timeout expired
css-components:build: cache bypass, force executing 0697386bf6a25838
css-components:build:
css-components:build: > [email protected] build /home/niuiic/Documents/projects/gallery/packages/css
css-components:build: > farm build -c farm.config.build.ts
css-components:build:
css-components:build: [ Farm ] Using config file at /home/niuiic/Documents/projects/gallery/packages/css/farm.config.build.ts
css-components:build: file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/config/schema.js:264
css-components:build:         throw new Error(`${validationError}. \n Please check your configuration file or command line configuration.`);
css-components:build:               ^
css-components:build:
css-components:build: Error: Validation error: Number must be greater than 0 at "compilation.partialBundling.targetMinSize".
css-components:build:  Please check your configuration file or command line configuration.
css-components:build:     at parseUserConfig (file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/config/schema.js:264:15)
css-components:build:     at resolveUserConfig (file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/config/index.js:293:26)
css-components:build:     at async build (file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/index.js:49:24)
css-components:build:
css-components:build: Node.js v21.1.0
css-components:build:  ELIFECYCLE  Command failed with exit code 1.
css-components:build: ERROR: command finished with error: command (/home/niuiic/Documents/projects/gallery/packages/css) pnpm run build exited (1)
css-components#build: command (/home/niuiic/Documents/projects/gallery/packages/css) pnpm run build exited (1)

set enforceResources and targetMinSize

farm-plugins:build: cache bypass, force executing 106922e0314b13a1
farm-plugins:build:
farm-plugins:build: > [email protected] build /home/niuiic/Documents/projects/gallery/packages/farm-plugins
farm-plugins:build: > farm build
farm-plugins:build:
farm-plugins:build: [ Farm ] Using config file at /home/niuiic/Documents/projects/gallery/packages/farm-plugins/farm.config.ts
farm-plugins:build: [ Farm ] ⚡️ Build completed in 34ms! Resources emitted to dist.
farm-plugins:build: [ FarmDtsPlugin ] ⚡️ Dts Plugin Build completed in 744ms! Resources emitted to dist.
farm-plugins:build: Failed to mark outputs as cached for farm-plugins#build: rpc error: code = Unavailable desc = cookie timeout expired
css-components:build: cache bypass, force executing 3f5023f3be6a3a68
css-components:build:
css-components:build: > [email protected] build /home/niuiic/Documents/projects/gallery/packages/css
css-components:build: > farm build -c farm.config.build.ts
css-components:build:
css-components:build: [ Farm ] Using config file at /home/niuiic/Documents/projects/gallery/packages/css/farm.config.build.ts
css-components:build: file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/config/schema.js:264
css-components:build:         throw new Error(`${validationError}. \n Please check your configuration file or command line configuration.`);
css-components:build:               ^
css-components:build:
css-components:build: Error: Validation error: Number must be greater than 0 at "compilation.partialBundling.targetMinSize".
css-components:build:  Please check your configuration file or command line configuration.
css-components:build:     at parseUserConfig (file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/config/schema.js:264:15)
css-components:build:     at resolveUserConfig (file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/config/index.js:293:26)
css-components:build:     at async build (file:https:///home/niuiic/Documents/projects/gallery/node_modules/.pnpm/@[email protected]/node_modules/@farmfe/core/dist/index.js:49:24)
css-components:build:
css-components:build: Node.js v21.1.0
css-components:build:  ELIFECYCLE  Command failed with exit code 1.
css-components:build: ERROR: command finished with error: command (/home/niuiic/Documents/projects/gallery/packages/css) pnpm run build exited (1)
css-components#build: command (/home/niuiic/Documents/projects/gallery/packages/css) pnpm run build exited (1)

 Tasks:    1 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.367s
Failed:    css-components#build

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Command failed with exit code 1.

wre232114 · 2023-11-22T07:58:04Z

my mistake, you can set targetMinSize to 1, cause it can not be zero for now

niuiic · 2023-11-22T08:09:16Z

Three components and three output files. This works. But it seems there is still something wrong with enforceResources.

Test should be correct now.

css-components:build: [
css-components:build:   {
css-components:build:     name: 'wavyUnderline',
css-components:build:     test: [ 'src/components/wavyUnderline/.*' ]
css-components:build:   }
css-components:build: ]

wre232114 · 2023-11-22T08:10:50Z

I'll check enforceResources, it should work too.

niuiic · 2023-11-22T08:11:43Z

wavyUnderline/index.ts import raw string from wavyUnderline/wavyUnderline.html and wavyUnderline/wavyUnderline.scss, and then export these.

index.ts export all thing from wavyUnderline/index.ts.

No dynamic import.

niuiic · 2023-11-22T08:22:39Z

Unfortunately, groups does not work either.

I forget to test the website.

wre232114 · 2023-11-22T08:52:49Z

This may be a issue related to bundling, I'll look into it

wre232114 · 2023-11-22T09:02:46Z

I found the reason, it will be fixed in 0.14.4

niuiic · 2023-11-23T07:01:47Z

This is not fixed in 0.14.4.

@wre232114

wre232114 · 2023-11-23T07:56:11Z

I'll try, it works with my examples

wre232114 · 2023-11-23T11:38:27Z

entryFilename: 'index.mjs' should be entryFilename: '[entryName].mjs'. index.mjs will overide all entries name including the farm runtime.

I'll make farm runtime not affect by this option in 0.14.5 too.

wre232114 · 2023-11-24T00:07:16Z

fixed in 0.14.5

niuiic · 2023-11-24T01:12:41Z

This is fixed.

Nirvana-Jie added the bug Something isn't working label Nov 22, 2023

niuiic closed this as completed Nov 22, 2023

niuiic reopened this Nov 22, 2023

wre232114 added a commit that referenced this issue Nov 23, 2023

fix: #769

668688d

wre232114 closed this as completed in dbecdf5 Nov 23, 2023

github-actions bot mentioned this issue Nov 23, 2023

Version Packages #772

Merged

wre232114 reopened this Nov 23, 2023

niuiic closed this as completed Nov 24, 2023

github-actions bot mentioned this issue Feb 6, 2024

chore: release #968

Merged

This was referenced Mar 11, 2024

chore: release #1009

Merged

chore: release #1015

Merged

github-actions bot mentioned this issue Mar 13, 2024

chore: release #1021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] partialBundling causes an error in the build product #769

[Bug] partialBundling causes an error in the build product #769

niuiic commented Nov 22, 2023 •

edited

Loading

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023

niuiic commented Nov 22, 2023 •

edited

Loading

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023 •

edited

Loading

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 23, 2023 •

edited

Loading

wre232114 commented Nov 23, 2023

wre232114 commented Nov 23, 2023

wre232114 commented Nov 24, 2023

niuiic commented Nov 24, 2023

[Bug] partialBundling causes an error in the build product #769

[Bug] partialBundling causes an error in the build product #769

Comments

niuiic commented Nov 22, 2023 • edited Loading

Steps to reproduce

What is expected?

What is actually happening?

System Info

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023

niuiic commented Nov 22, 2023 • edited Loading

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 22, 2023 • edited Loading

niuiic commented Nov 22, 2023

wre232114 commented Nov 22, 2023

wre232114 commented Nov 22, 2023

niuiic commented Nov 23, 2023 • edited Loading

wre232114 commented Nov 23, 2023

wre232114 commented Nov 23, 2023

wre232114 commented Nov 24, 2023

niuiic commented Nov 24, 2023

niuiic commented Nov 22, 2023 •

edited

Loading

niuiic commented Nov 22, 2023 •

edited

Loading

niuiic commented Nov 22, 2023 •

edited

Loading

niuiic commented Nov 23, 2023 •

edited

Loading