fix(ext/node): add APIs perf_hook.performance (denoland#21192)

Required for Next.js.
fanbaby · Nov 14, 2023 · cf6673b · cf6673b
1 parent 8866521
commit cf6673b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/cli/tests/unit_node/perf_hooks_test.ts b/cli/tests/unit_node/perf_hooks_test.ts
@@ -13,12 +13,22 @@ Deno.test({
  assertEquals(perfHooks.performance.clearMarks, performance.clearMarks);
  assertEquals(perfHooks.performance.mark, performance.mark);
  assertEquals(perfHooks.performance.now, performance.now);
+ assertEquals(
+ perfHooks.performance.getEntriesByName,
+ performance.getEntriesByName,
+ );
+ assertEquals(
+ perfHooks.performance.getEntriesByType,
+ performance.getEntriesByType,
+ );
  // @ts-ignore toJSON is not in Performance interface
  assertEquals(perfHooks.performance.toJSON, performance.toJSON);
  perfHooks.performance.measure("test");
  perfHooks.performance.mark("test");
  perfHooks.performance.clearMarks("test");
  perfHooks.performance.now();
+ assertEquals(perfHooks.performance.getEntriesByName("event", "mark"), []);
+ assertEquals(perfHooks.performance.getEntriesByType("mark"), []);
  // @ts-ignore toJSON is not in Performance interface
  perfHooks.performance.toJSON();
  },

diff --git a/ext/node/polyfills/perf_hooks.ts b/ext/node/polyfills/perf_hooks.ts
@@ -16,7 +16,7 @@ const constants = {};
 const performance:
  & Omit<
  Performance,
- "clearMeasures" | "getEntries" | "getEntriesByName" | "getEntriesByType"
+ "clearMeasures" | "getEntries"
  >
  & {
  // deno-lint-ignore no-explicit-any
@@ -58,6 +58,9 @@ const performance:
  // deno-lint-ignore no-explicit-any
  return (shimPerformance as any).timeOrigin;
  },
+ getEntriesByName: (name, type) =>
+ shimPerformance.getEntriesByName(name, type),
+ getEntriesByType: (type) => shimPerformance.getEntriesByType(type),
  markResourceTiming: () => {},
  // @ts-ignore waiting on update in `deno`, but currently this is
  // a circular dependency