forked from denoland/deno
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: improve
deno doc --lint
error messages (denoland#21156)
This also updates deno_graph, which has the JSR change to use "exports". It's not yet useful atm, so I've made this PR a fix about the deno doc --lint error message improvements. I'll do a follow-up PR that adds exports to the deno.json
- Loading branch information
Showing
17 changed files
with
62 additions
and
35 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,7 +69,7 @@ fn specifiers_in_lockfile() { | |
|
||
temp_dir.write( | ||
"main.ts", | ||
r#"import version from "jsr:@denotest/[email protected]/mod.ts"; | ||
r#"import version from "jsr:@denotest/[email protected]"; | ||
console.log(version);"#, | ||
); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
Type 'MyClass' references type 'MyInterface' which is not exported from a root module. | ||
Missing JS documentation comment. | ||
Missing JSDoc comment. | ||
at file:https:///[WILDCARD]/referenced_private_types.ts:5:1 | ||
|
||
Missing JS documentation comment. | ||
Type 'MyClass.prototype.prop' references type 'MyInterface' which is not exported from a root module. | ||
Missing JSDoc comment. | ||
at file:https:///[WILDCARD]/referenced_private_types.ts:6:3 | ||
|
||
error: Found 3 documentation diagnostics. | ||
error: Found 3 documentation lint errors. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import value from "jsr:@denotest/deps/mod.ts"; | ||
import value from "jsr:@denotest/deps"; | ||
|
||
console.log(value); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import { Test } from "jsr:@denotest/module_graph/mod.ts"; | ||
import { Test } from "jsr:@denotest/module_graph"; | ||
|
||
console.log(new Test()); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import version, { TestClass } from "jsr:@denotest/[email protected]/mod.ts"; | ||
import version, { TestClass } from "jsr:@denotest/[email protected]"; | ||
|
||
console.log(version); | ||
console.log(new TestClass()); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import version1 from "jsr:@denotest/[email protected]/mod.ts"; | ||
import version2 from "jsr:@denotest/no_module_graph@^0.2/mod.ts"; | ||
import version1 from "jsr:@denotest/[email protected]"; | ||
import version2 from "jsr:@denotest/no_module_graph@^0.2"; | ||
|
||
console.log(version1); | ||
console.log(version2); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 9 additions & 6 deletions
15
cli/tests/testdata/jsr/registry/@denotest/deps/1.0.0_meta.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
cli/tests/testdata/jsr/registry/@denotest/module_graph/1.4.0_meta.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
{ | ||
"exports": { | ||
".": "./mod.ts", | ||
"./other": "./other.ts" | ||
}, | ||
"moduleGraph1": { | ||
"/mod.ts": { | ||
"dependencies": [{ | ||
|
6 changes: 5 additions & 1 deletion
6
cli/tests/testdata/jsr/registry/@denotest/no_module_graph/0.1.0_meta.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
{} | ||
{ | ||
"exports": { | ||
".": "./mod.ts" | ||
} | ||
} |
6 changes: 5 additions & 1 deletion
6
cli/tests/testdata/jsr/registry/@denotest/no_module_graph/0.1.1_meta.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
{} | ||
{ | ||
"exports": { | ||
".": "./mod.ts" | ||
} | ||
} |
6 changes: 5 additions & 1 deletion
6
cli/tests/testdata/jsr/registry/@denotest/no_module_graph/0.2.0_meta.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
{} | ||
{ | ||
"exports": { | ||
".": "./mod.ts" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters