Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add retry logic for file upload & fallback repository #277

Merged
merged 12 commits into from
Sep 4, 2024
Merged

feat: add retry logic for file upload & fallback repository #277

merged 12 commits into from
Sep 4, 2024

Conversation

badayvedat
Copy link
Contributor

@badayvedat badayvedat commented Aug 13, 2024 •
edited
Loading

This PR aims to increase the resiliency of the file uploads.

  1. It introduces an exponential backoff retry for file repositories listed below:
  • fal (gcp)
  • fal v2 (v2.fal.media)
  • in memory (we don't need it) (b64)
  • gcp
  • r2
  • cdn (fal.media)
  1. Updates the default file repository to "fal_v2" (v2.fal.media) from "fal" (gcp)
  2. Introduces a fallback repository parameter with a default set to "cdn" (fal.media).

@badayvedat badayvedat changed the title feat: add retry logic for file upload feat: add retry logic for file upload & fallback repository Aug 13, 2024
@badayvedat badayvedat requested a review from efiop August 13, 2024 13:38
@efiop
Copy link
Contributor

efiop commented Aug 13, 2024

I'll take a look at the failing ones.

@efiop
Copy link
Contributor

efiop commented Aug 23, 2024

Please excuse the delay, I'm will get this in today.

@badayvedat badayvedat changed the title feat: add retry logic for file upload & fallback repository [DO NOT MERGE] feat: add retry logic for file upload & fallback repository Sep 4, 2024
@badayvedat badayvedat changed the title [DO NOT MERGE] feat: add retry logic for file upload & fallback repository feat: add retry logic for file upload & fallback repository Sep 4, 2024
@badayvedat badayvedat merged commit f46a721 into main Sep 4, 2024
6 checks passed
@badayvedat badayvedat deleted the vedat/fea-3098-featfal-sdk-retry-mechanism-to-uploads branch September 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badayvedat @efiop