Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from = 1.28.2 to = 1.35.1 #2548

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 29, 2022

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.35.1

Bug fixes

  • #10926: Make Style/SafeNavigation aware of a redundant nil check. (@​koic)
  • #10944: Fix an incorrect autocorrect for Lint/LiteralInInterpolation when using "#{nil}". (@​koic)
  • #10921: Fix an error when ERB pre-processing of the configuration file. (@​koic)
  • #10936: Fix an error for Lint/NonAtomicFileOperation when using FileTest.exist? as a condition for elsif. (@​koic)
  • #10920: Fix an incorrect autocorrect for Style/SoleNestedConditional when using nested conditional and branch contains a comment. (@​koic)
  • #10939: Fix an error for Style/Next when line break before condition. (@​koic)

RuboCop 1.35

New features

Bug fixes

  • #10899: Fix an error for Lint/ShadowingOuterLocalVariable when the same variable name as a block variable is used in return value assignment of if. (@​koic)
  • #10916: Fix an error when .rubocop.yml is empty. (@​koic)
  • #10915: Fix numblock support to Layout/BlockAlignment, Layout/BlockEndNewline, Layout/EmptyLinesAroundAccessModifier, Layout/EmptyLinesAroundBlockBody, Layout/IndentationWidth, Layout/LineLength, Layout/MultilineBlockLayout, Layout/SpaceBeforeBlockBraces, Lint/NextWithoutAccumulator, Lint/NonDeterministicRequireOrder, Lint/RedundantWithIndex, Lint/RedundantWithObject, Lint/UnreachableLoop, Lint/UselessAccessModifier, Lint/Void, Metrics/AbcSize, Metrics/CyclomaticComplexity, Style/CollectionMethods, Style/CombinableLoops, Style/EachWithObject, Style/For, Style/HashEachMethods, Style/InverseMethods, Style/MethodCalledOnDoEndBlock, Style/MultilineBlockChain, Style/Next, Style/ObjectThen, Style/Proc, Style/RedundantBegin, Style/RedundantSelf, Style/RedundantSortBy and Style/TopLevelMethodDefinition. (@​gsamokovarov)
  • #10895: Fix incorrect autocomplete in Style/RedundantParentheses when a heredoc is used in an array. (@​dvandersluis)
  • #10909: Fix loading behavior on running without bundle exec. (@​r7kamura)
  • #10913: Make Style/ArgumentsForwarding aware of anonymous block argument. (@​koic)
  • #10911: Fix Style/ClassMethodsDefinitions for non-self receivers. (@​sambostock)

Changes

RuboCop 1.34.1

Bug fixes

  • #10893: Fix an error when running rubocop without bundle exec. (@​koic)

RuboCop 1.34

New features

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.35.1 (2022-08-22)

Bug fixes

  • #10926: Make Style/SafeNavigation aware of a redundant nil check. ([@​koic][])
  • #10944: Fix an incorrect autocorrect for Lint/LiteralInInterpolation when using "#{nil}". ([@​koic][])
  • #10921: Fix an error when ERB pre-processing of the configuration file. ([@​koic][])
  • #10936: Fix an error for Lint/NonAtomicFileOperation when using FileTest.exist? as a condition for elsif. ([@​koic][])
  • #10920: Fix an incorrect autocorrect for Style/SoleNestedConditional when using nested conditional and branch contains a comment. ([@​koic][])
  • #10939: Fix an error for Style/Next when line break before condition. ([@​koic][])

1.35.0 (2022-08-12)

New features

Bug fixes

  • #10899: Fix an error for Lint/ShadowingOuterLocalVariable when the same variable name as a block variable is used in return value assignment of if. ([@​koic][])
  • #10916: Fix an error when .rubocop.yml is empty. ([@​koic][])
  • #10915: Fix numblock support to Layout/BlockAlignment, Layout/BlockEndNewline, Layout/EmptyLinesAroundAccessModifier, Layout/EmptyLinesAroundBlockBody, Layout/IndentationWidth, Layout/LineLength, Layout/MultilineBlockLayout, Layout/SpaceBeforeBlockBraces, Lint/NextWithoutAccumulator, Lint/NonDeterministicRequireOrder, Lint/RedundantWithIndex, Lint/RedundantWithObject, Lint/UnreachableLoop, Lint/UselessAccessModifier, Lint/Void, Metrics/AbcSize, Metrics/CyclomaticComplexity, Style/CollectionMethods, Style/CombinableLoops, Style/EachWithObject, Style/For, Style/HashEachMethods, Style/InverseMethods, Style/MethodCalledOnDoEndBlock, Style/MultilineBlockChain, Style/Next, Style/ObjectThen, Style/Proc, Style/RedundantBegin, Style/RedundantSelf, Style/RedundantSortBy and Style/TopLevelMethodDefinition. ([@​gsamokovarov][])
  • #10895: Fix incorrect autocomplete in Style/RedundantParentheses when a heredoc is used in an array. ([@​dvandersluis][])
  • #10909: Fix loading behavior on running without bundle exec. ([@​r7kamura][])
  • #10913: Make Style/ArgumentsForwarding aware of anonymous block argument. ([@​koic][])
  • #10911: Fix Style/ClassMethodsDefinitions for non-self receivers. ([@​sambostock][])

Changes

1.34.1 (2022-08-09)

Bug fixes

  • #10893: Fix an error when running rubocop without bundle exec. ([@​koic][])

1.34.0 (2022-08-09)

New features

Bug fixes

  • #10552: Require RuboCop AST 1.20.0+ to fix a false positive for Lint/OutOfRangeRegexpRef when using fixed-encoding regopt. ([@​koic][])
  • #10512: Fix a false positive for Lint/ShadowingOuterLocalVariable conditional statement and block variable. ([@​ydah][])
  • #10864: min and max results in false positives for Style/SymbolProc similarly to select and reject. ([@​mollerhoj][])
  • #10846: Fix a false negative for Style/DoubleNegation when there is a hash or an array at return location of method. ([@​nobuyo][])

... (truncated)

Commits
  • 9439334 Cut 1.35.1
  • a06806d Update Changelog
  • 1597468 [Fix #10939] Fix an error for Style/Next
  • e99bc6c Merge pull request #10945 from koic/fix_an_incorrect_autocorrect_for_lint_lit...
  • 0048f70 Merge pull request #10946 from fatkodima/safe-navigation-negated
  • 1c0e98d Fix Style/SafeNavigation for negated method call with a safe navigation
  • b69ca43 [Fix #10944] Fix an incorrect autocorrect for Lint/LiteralInInterpolation
  • dc09aae Make InternalAffairs/SingleLineComparison aware of negative comparison
  • 23a3924 Merge pull request #10941 from fatkodima/fix-prof-slow_cops
  • bd8a7ca Fix rake prof:slow_cops to return correct results
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 29, 2022
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.35.1 branch from 021a5b3 to e164eba Compare August 30, 2022 00:02
@dmarcoux
Copy link
Contributor

Since this PR was opened, the RuboCop config changed on master so rebasing is needed.

@stefannibrasil
Copy link

@dependabot rebase

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.28.2...v1.35.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-1.35.1 branch from e164eba to f02bfe4 Compare August 31, 2022 23:49
@stefannibrasil
Copy link

thanks @dmarcoux merging it now.

@stefannibrasil stefannibrasil merged commit 572c22a into master Aug 31, 2022
@stefannibrasil stefannibrasil deleted the dependabot/bundler/rubocop-1.35.1 branch August 31, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants