Add finance/stock generators #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
suggested changes
Oct 10, 2020
Zeragamba
approved these changes
Oct 13, 2020
|
Thanks! |
|
You're welcome! Very happy I finally had a chance to contribute to some open-source projects! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Add finance/stock generators * Address comments from PR
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 20c7afc.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 20c7afc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution for issue #1511 and #1517
Uses the code contributed in #1517 but removes all the unnecessary changes.
This PR adds a generator that generates stock ticker symbols (e.g. AAPL, GOOG). Pretty basic but lays a foundation that can include other stock/equity information such as last/bid/ask price, volume, etc...