Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break geometry.go & geometry_test.go into multiple smaller files #287

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Break geometry.go & geometry_test.go into multiple smaller files #287

merged 4 commits into from
Aug 17, 2021

Conversation

cebarks
Copy link
Collaborator

@cebarks cebarks commented Jun 22, 2021

Closes #286.

@cebarks cebarks self-assigned this Jun 22, 2021
@cebarks cebarks marked this pull request as draft June 22, 2021 19:38
@faiface
Copy link
Owner

faiface commented Jun 22, 2021

While Pixel is not technically 1.0, it's being used as it is and breaking changes should only be introduced in cases where they bring substantial benefits to the users of the library. Which I don't think is the case for this change. I appreciate the effort, but I don't think this is a good idea.

@cebarks
Copy link
Collaborator Author

cebarks commented Jun 22, 2021

That's fair @faiface, as I did it the more i thought maybe it wasn't the best idea. What do you think about still breaking out geometry.go into multiple files?

@faiface
Copy link
Owner

faiface commented Jun 22, 2021

Yes, breaking it up sounds good. It would make things easier to navigate.

@cebarks cebarks changed the title WIP: Move geometry into its own package and beak up into multiple files Move geometry into its own package and beak up into multiple files Jun 22, 2021
@cebarks cebarks marked this pull request as ready for review June 22, 2021 21:16
@cebarks cebarks changed the title Move geometry into its own package and beak up into multiple files Break geometry.go into multiple smaller files Jun 23, 2021
@cebarks cebarks changed the title Break geometry.go into multiple smaller files Break geometry.go & geometry_test.go into multiple smaller files Jun 23, 2021
@dusk125
Copy link
Collaborator

dusk125 commented Aug 16, 2021

@cebarks can you check to make sure that any new changes tests in geometry are merged into your broken out files please before I merge this in?

@cebarks
Copy link
Collaborator Author

cebarks commented Aug 17, 2021

@cebarks can you check to make sure that any new changes tests in geometry are merged into your broken out files please before I merge this in?

Should be good to go now @dusk125 :)

dusk125
dusk125 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@dusk125 dusk125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dusk125 dusk125 merged commit 4964768 into faiface:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusk125 dusk125 dusk125 approved these changes

Assignees

@cebarks cebarks

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Geometry into its own package
3 participants
@cebarks @faiface @dusk125