Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature!/eleventy-img shortcode #25

Merged
merged 25 commits into from
Jun 2, 2022
Merged

Conversation

dnnsjrng
Copy link
Member

@dnnsjrng dnnsjrng commented May 26, 2022

  • this implements the @11ty/eleventy-img plugin as a shortcode for twig
  • due to necessary new config options I changed the userOptions properties
  • extract shortcodes to separate files to keep the main plugin/shortcode file clean
  • update the readme accordingly, highlight the features in a separate section at the top, add shortcode descriptions
  • asset_path now returns just the userOptions.assets.base folder

@dnnsjrng dnnsjrng added enhancement New feature or request breaking changes labels May 26, 2022
@dnnsjrng dnnsjrng self-assigned this May 26, 2022
@dnnsjrng dnnsjrng requested review from mgrsskls and mvsde May 26, 2022 14:39
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/shortcodes/image.js Outdated Show resolved Hide resolved
lib/shortcodes/image.js Outdated Show resolved Hide resolved
lib/shortcodes/image.js Outdated Show resolved Hide resolved
lib/shortcodes/image.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/shortcodes/image.js Outdated Show resolved Hide resolved
@dnnsjrng
Copy link
Member Author

dnnsjrng commented May 31, 2022

To not increase the complexity and size of this PR, I would suggest to give those topics:

... to their own feature requests and move them to separate PRs. Agreed?

mvsde added 2 commits June 2, 2022 10:05
The urlPath is used by eleventy-img to construct the HTML source path for the images. `path.join` on Windows creates paths with backslashes instead of the required normal slashes.
@dnnsjrng dnnsjrng merged commit 06b0ef6 into main Jun 2, 2022
@mvsde mvsde deleted the feature/eleventy-image-shortcode branch June 2, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants