Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/default shortcodes and object rework #19

Merged
merged 18 commits into from
May 24, 2022
Merged

feature/default shortcodes and object rework #19

merged 18 commits into from
May 24, 2022

Conversation

dnnsjrng
Copy link
Member

@dnnsjrng dnnsjrng commented May 18, 2022 •
edited

  • add {{ mix }} and {{ asset_path }} as default shortcodes
  • implement mix shortcode properly
  • rework object structure
  • fix reduce bug in extendTwig

@dnnsjrng dnnsjrng self-assigned this May 18, 2022
@dnnsjrng dnnsjrng changed the title feature/add default shortcodes Draft: feature/add default shortcodes May 18, 2022
mvsde
mvsde reviewed May 18, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@dnnsjrng dnnsjrng changed the title Draft: feature/add default shortcodes Draft: feature/default shortcodes and object rework May 19, 2022
@dnnsjrng dnnsjrng changed the title Draft: feature/default shortcodes and object rework feature/default shortcodes and object rework May 19, 2022
@dnnsjrng dnnsjrng requested review from mgrsskls and mvsde May 19, 2022 12:10
mvsde
mvsde requested changes May 20, 2022
View reviewed changes
lib/shortcodes.js Outdated Show resolved Hide resolved
lib/plugin.js Outdated Show resolved Hide resolved
lib/plugin.js Outdated Show resolved Hide resolved
@dnnsjrng dnnsjrng requested a review from mvsde May 23, 2022 14:17
mvsde
mvsde requested changes May 24, 2022
View reviewed changes
lib/plugin.js Show resolved Hide resolved
lib/plugin.js Outdated Show resolved Hide resolved
@dnnsjrng dnnsjrng requested a review from mvsde May 24, 2022 08:29
mvsde
mvsde approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@mvsde mvsde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works fine 👍🏻

@dnnsjrng dnnsjrng merged commit 56b3652 into main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvsde mvsde mvsde approved these changes

@mgrsskls mgrsskls Awaiting requested review from mgrsskls

Assignees

@dnnsjrng dnnsjrng

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnnsjrng @mgrsskls @mvsde