Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to peewee > 3 #113

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Adapt to peewee > 3 #113

merged 1 commit into from
Oct 29, 2018

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 25, 2018 •
edited
Loading

This adapts the breaking changes in peewee 3.0 (current version is 3.7)

@maxnoe maxnoe requested a review from kbruegge October 25, 2018 22:33
@maxnoe maxnoe mentioned this pull request Oct 29, 2018
Closed
@dneise
Copy link
Member

dneise commented Oct 29, 2018

Awesome, did you make the models.py with pwiz? So we do not have to review it? Or did you make it somehow by hand?

dneise
dneise approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@dneise dneise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did not read every diff in models.py though

@maxnoe
Copy link
Member Author

maxnoe commented Oct 29, 2018

Awesome, did you make the models.py with pwiz? So we do not have to review it? Or did you make it somehow by hand?

I used the peewee tool to generate models from a database connection.
I know just used search and replace to adapt to the changes in peewee 3

@dneise
Copy link
Member

dneise commented Oct 29, 2018

Ah right ... search and replace should be fine

@maxnoe maxnoe merged commit 514ef47 into master Oct 29, 2018
@maxnoe maxnoe deleted the update_peewee branch October 29, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneise dneise dneise approved these changes

@kbruegge kbruegge Awaiting requested review from kbruegge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxnoe @dneise