Implementation Improvement for nougat.inference #72
Conversation
In the inference process, it appears that [the forward pass of the encoder is executed twice](https://github.com/facebookresearch/nougat/blob/c8c33a6e83da8d8ca56c47ac77cfcfe5fc2ebfe0/nougat/model.py#L577-L580), and the output of the second run consistently overwrites the results of the first run.
|
Hi @kq-chen! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
wow how did that happen .. good catch, thanks |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
In the inference process, it appears that the forward pass of the encoder is executed twice, and the output of the second run consistently overwrites the results of the first run.