Fix supportsFlatNoNullsFastPath for SimpleFunctionAdapter #7432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 6, 2023
…cubator#7432) Summary: If the function has is_default_contains_nulls_behavior it returns null if the data contains null even if the return type of callNullFree is void, hence supportsFlatNoNullsFastPath should be false in that case, Fix facebookincubator#7420 Differential Revision: D51005043
2157874
to
ee8660b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 6, 2023
…cubator#7432) Summary: If the function has is_default_contains_nulls_behavior it returns null if the data contains null even if the return type of callNullFree is void, hence supportsFlatNoNullsFastPath should be false in that case, Fix facebookincubator#7420 Differential Revision: D51005043
ee8660b
to
728611e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 6, 2023
…cubator#7432) Summary: If the function has is_default_contains_nulls_behavior it returns null if the data contains null even if the return type of callNullFree is void, hence supportsFlatNoNullsFastPath should be false in that case, Fix facebookincubator#7420 Differential Revision: D51005043
728611e
to
9ef157a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 6, 2023
…cubator#7432) Summary: If the function has is_default_contains_nulls_behavior it returns null if the data contains null even if the return type of callNullFree is void, hence supportsFlatNoNullsFastPath should be false in that case, Fix facebookincubator#7420 Differential Revision: D51005043
9ef157a
to
ad6e9e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
…cubator#7432) Summary: If the function has is_default_contains_nulls_behavior it returns null if the data contains null even if the return type of callNullFree is void, hence supportsFlatNoNullsFastPath should be false in that case, Fix facebookincubator#7420 Differential Revision: D51005043
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Nov 6, 2023
…cubator#7432) Summary: If the function has is_default_contains_nulls_behavior it returns null if the data contains null even if the return type of callNullFree is void, hence supportsFlatNoNullsFastPath should be false in that case, Fix facebookincubator#7420 Differential Revision: D51005043
ad6e9e0
to
1d054d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
1d054d6
to
974632a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51005043 |
|
This pull request has been merged in d749ff8. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
JkSelf
added a commit
to JkSelf/velox
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If the function has is_default_contains_nulls_behavior it returns
null if the data contains null even if the return type of callNullFree is void,
hence supportsFlatNoNullsFastPath should be false in that cass.
Fix #7420
Differential Revision: D51005043