Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Refactoring tests #900

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Refactoring tests #900

merged 1 commit into from
Dec 6, 2017

Conversation

carusogabriel
Copy link
Contributor

I've refactored some tests, using:

  • assertContains instead of in_array function;
  • assertCount instead of count function;
  • assertInternalType, avoiding using is_* functions;
  • assertArrayNotHasKey instead of isset function;

Nyholm
Nyholm approved these changes Dec 6, 2017
View reviewed changes
Copy link

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @carusogabriel. You are on fire with your refactoring of tests on different libraries. =)

@yguedidi yguedidi merged commit e8e5737 into facebookarchive:master Dec 6, 2017
@yguedidi
Copy link
Contributor

yguedidi commented Dec 6, 2017

Thanks you @carusogabriel!! Congrats for your first PR here ;)

@carusogabriel carusogabriel deleted the refactoring-tests branch December 6, 2017 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yguedidi yguedidi yguedidi approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carusogabriel @yguedidi @Nyholm @facebook-github-bot