Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Add a final class holding all permissions #381

Merged
merged 1 commit into from
Mar 31, 2015
Merged

Add a final class holding all permissions #381

merged 1 commit into from
Mar 31, 2015

Conversation

0x46616c6b
Copy link

For the comfort a final class holding all permissions as a constant for easier usage.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yguedidi
Copy link
Contributor

Can be useful, but it should go to master :)

@0x46616c6b
Copy link
Author

What is the plan with the 4.0.* versions? It would be great when I can use the constants with the next minor update. I can additionally create a PR for the master.

@yguedidi
Copy link
Contributor

ping @gfosco

@0x46616c6b
Copy link
Author

@txptr where is the permission documentated?

@SammyK
Copy link
Contributor

SammyK commented Mar 27, 2015

There's also a new user_posts permission in v2.3.

@SammyK
Copy link
Contributor

SammyK commented Mar 27, 2015

And the publish_pages docs are here.

@0x46616c6b
Copy link
Author

Bleeding edge ;-) I will add it.

@gfosco
Copy link
Contributor

gfosco commented Mar 31, 2015

Ok.. I'll accept this and tag a point release of 4.0.x. Consider sending in a PR against Master as well. Thanks.

gfosco added a commit that referenced this pull request Mar 31, 2015
Add a final class holding all permissions
@gfosco gfosco merged commit b583b4a into facebookarchive:4.0-dev Mar 31, 2015
@gfosco
Copy link
Contributor

gfosco commented Mar 31, 2015

4.0.21 tagged with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants