This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
revert interface change #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really a breaking change?.. I don't mind removing this type hinting, but what did it break? |
|
Ah yes, the |
|
@gfosco yes it's a BC break |
|
@SammyK I'm late lol! |
|
Beat you to it by seconds! :D |
|
Haven't run into this before with a tagged release... Should I tag this 4.0.18 or delete and re-tag 4.0.17? |
|
I'd just tag 4.0.18 and count 4.0.17 as a bug release. |
|
Moved too quickly, it's tagged 4.0.18 but the readme badge and the version string are still .17... (tableflip) |
|
Lol |
|
Fixed. Thanks all. |
|
👍 |
|
Thanks for a swift reaction! :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You made a breaking change to an interface in a minor patch library fix (
4.0.16→4.0.17). This fucks up any library implementing this interface. According to semantic versioning this should be a major version bump, so I suggest reverting this change.