This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Making fbctf great again #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfxn
approved these changes
Oct 17, 2018
azjezz
suggested changes
Apr 24, 2019
| @@ -131,7 +131,7 @@ class="fb-cta cta--yellow"> | |||
| $next_game_text = tr('Soon'); | |||
| $countdown = array('--', '--', '--', '--'); | |||
| } else { | |||
| $next_game_text = date(tr('date and time format'), $next_game); | |||
| $next_game_text = date('H:i:s T D m/d/y', $next_game); | |||
There was a problem hiding this comment.
This makes fbctf less customizable.
if we are not using a translation here, a constant string containing the format should be added to the controller ( e.g IndexController::NEXT_GAME_DATE_FORMAT )
| if ($language === 'en' && $word != 'date and time format') { // temporary fix for | ||
| return $word; // reducing function calls to | ||
| } // tr() | ||
| elseif (array_key_exists($word, $lang)) { |
There was a problem hiding this comment.
there should be no language exception here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing several bugs and adding some changes that were added to the
dev-litein the mainfbctfproject. The commits that were added are:Due to the lack of details provided with these commits, it requires some deep understanding of what is going on in the code to fully get what is done. They are a mix between an attempt to increase the performance and fix various bugs.