Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual to void timeoutExpired() function. #181

Closed
wants to merge 1 commit into from
Closed

Add virtual to void timeoutExpired() function. #181

wants to merge 1 commit into from

Conversation

soyoo
Copy link

@soyoo soyoo commented Nov 5, 2020

It is more reasonable?

yfeldblum
yfeldblum requested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@yfeldblum yfeldblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation?

wangle/acceptor/ManagedConnection.h
@@ -50,7 +50,7 @@ class ManagedConnection:
};

// HHWheelTimer::Callback API (left for subclasses to implement).
void timeoutExpired() noexcept override = 0;
virtual void timeoutExpired() noexcept = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is an override:

https://github.com/facebook/folly/blob/v2020.11.02.00/folly/io/async/AsyncTimeout.h#L79-L82

@soyoo soyoo closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfeldblum yfeldblum yfeldblum requested changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soyoo @yfeldblum @facebook-github-bot