Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Increase cmake test DISCOVERY_TIMEOUT from 5 to 120 seconds #8403

Closed
wants to merge 1 commit into from

Conversation

jay-zhuang
Copy link
Contributor

@jay-zhuang jay-zhuang commented Jun 14, 2021

Summary: cmake test discovery may timeout especially on Windows
platform. Increase it from default 5 seconds to 120 seconds.

Test Plan: Run Windows build 10 times without issue

Summary: cmake test discovery may timeout especially on Windows
platform. Increase it from default 5 seconds to 120 seconds.

Test Plan: Run Windows build 10 times without issue
@jay-zhuang jay-zhuang changed the title [WIP] Debug vs build [CI] Increase cmake test DISCOVERY_TIMEOUT from 5 to 120 seconds Jun 14, 2021
@jay-zhuang jay-zhuang marked this pull request as ready for review June 14, 2021 22:53
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@akankshamahajan15 akankshamahajan15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jay for the fix!

@facebook-github-bot
Copy link
Contributor

@jay-zhuang merged this pull request in 99908db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants