Add CreateFrom methods to Env/FileSystem #8174
Conversation
- Added CreateFromString method to Env and FilesSystem to replace LoadEnv/Load. This method/signature is a precursor to making these classes extend Customizable. - Added CreateFromSystem to Env. This method standardizes creating an Env from the environment variables. Previously, some places would check TEST_ENV_URI and others would also check TEST_FS_URI. Now the code is more command/standardized. - Added CreateFromFlags to Env. These method allows Env to be create from string options (such as GFLAGS options) in a more standard way.
75da41d
to
5b6ef84
Compare
299b321
to
6b8de69
Compare
tools/db_bench_tool.cc
Outdated
| } else if (FLAGS_simulate_hybrid_fs_file != "") { | ||
| FLAGS_env = GetCompositeEnv(std::make_shared<SimulatedHybridFileSystem>( | ||
| FileSystem::Default(), FLAGS_simulate_hybrid_fs_file)); | ||
| //**TODO: Make the siimulated fs something that can be loaded |
There was a problem hiding this comment.
nit: siimulated->simulate
tools/sst_dump_tool.cc
Outdated
| Status s = Env::CreateFromUri(config_options, env_uri, fs_uri, &options.env, | ||
| &env_guard); | ||
| if (!s.ok()) { | ||
| fprintf(stderr, "CreateEnv: %s\n", s.ToString().c_str()); |
There was a problem hiding this comment.
CreateEnv: ->CreateFromUri:
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrambacher has updated the pull request. You must reimport the pull request before landing. |
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrambacher has updated the pull request. You must reimport the pull request before landing. |
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrambacher has updated the pull request. You must reimport the pull request before landing. |
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mrambacher merged this pull request in 281ac9c. |
Added CreateFromString method to Env and FilesSystem to replace LoadEnv/Load. This method/signature is a precursor to making these classes extend Customizable.
Added CreateFromSystem to Env. This method standardizes creating an Env from the environment variables. Previously, some places would check TEST_ENV_URI and others would also check TEST_FS_URI. Now the code is more command/standardized.
Added CreateFromFlags to Env. These method allows Env to be create from string options (such as GFLAGS options) in a more standard way.