Fix FilterBench when RTTI=0 #6732
Conversation
|
Hi @pallas! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
The dynamic_cast in the filter benchmark causes release mode to fail due to no-rtti. Replace with static_cast_with_check. Signed-off-by: Derrick Pallas <[email protected]>
0df13cd
to
80bf70e
Compare
util/filter_bench.cc
Outdated
| @@ -378,7 +381,7 @@ void FilterBench::Go() { | |||
| info.filter_ = info.plain_table_bloom_->GetRawData(); | |||
| } else { | |||
| if (!builder) { | |||
| builder.reset(&dynamic_cast<BuiltinFilterBitsBuilder &>(*GetBuilder())); | |||
| builder.reset(static_cast_with_check<BuiltinFilterBitsBuilder, FilterBitsBuilder>(GetBuilder())); | |||
There was a problem hiding this comment.
The second template argument should not be needed, unless some compiler needs it (which apparently we would not be compiling db_flush_test.cc with).
b2367ef
to
df1947e
Compare
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
df1947e
to
7fe6e91
Compare
|
@pallas has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in 5272305. |
The dynamic_cast in the filter benchmark causes release mode to fail due to
no-rtti. Replace with static_cast_with_check.
Signed-off-by: Derrick Pallas [email protected]
Addition by peterd: Remove unnecessary 2nd template arg on all static_cast_with_check