Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang analyze error #6622

Closed
wants to merge 1 commit into from
Closed

Fix clang analyze error #6622

wants to merge 1 commit into from

Conversation

riversand963
Copy link
Contributor

@riversand963 riversand963 commented Apr 1, 2020 •
edited
Loading

Summary:
As title. #6612 caused clang analyze to fail with the error:

db/compaction/compaction_picker_fifo.cc:105:39: warning: Called C++ object pointer is null
                     cf_name.c_str(), f->fd.GetNumber(), creation_time);
                                      ^~~~~~~~~~~~~~~~~
./logging/logging.h:59:36: note: expanded from macro 'ROCKS_LOG_BUFFER'
                                 ##__VA_ARGS__)
                                   ^~~~~~~~~~~
1 warning generated.

Test Plan (devserver):
USE_CLANG=1 make analyze

@riversand963
Fix clang analyze error
9d4af0f 
Summary:
As title.

Test Plan (devserver):
USE_CLANG=1 make analyze
facebook-github-bot
facebook-github-bot reviewed Apr 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@riversand963 riversand963 deleted the fix-clang-analyze branch April 1, 2020 17:05
@facebook-github-bot
Copy link
Contributor

@riversand963 merged this pull request in b5818f8.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@riversand963 merged this pull request in b5818f8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ltamasi ltamasi ltamasi approved these changes

@anand1976 anand1976 Awaiting requested review from anand1976

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riversand963 @facebook-github-bot @ltamasi