Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checksum handshake for WAL fragment decompression #10339

Closed
wants to merge 5 commits into from
Closed

Add checksum handshake for WAL fragment decompression #10339

wants to merge 5 commits into from

Conversation

cbi42
Copy link
Member

@cbi42 cbi42 commented Jul 11, 2022 •
edited
Loading

If WAL compression is enabled, WAL fragment decompression results are concatenated together in log::Reader::ReadPhysicalRecord(). This PR adds checksum handshake to protect memory corruption during the copying process.

checksum is renamed to record_checksum in ReadRecord() to differentiate it from checksum_ flag that specifies whether CRC32C checksum is verified.

Test plan: added checksum verification in log_test.cc, make check -j32.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cbi42 cbi42 marked this pull request as ready for review July 11, 2022 21:23
@cbi42 cbi42 requested a review from ajkr July 11, 2022 21:23
@facebook-github-bot
Copy link
Contributor

@cbi42 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cbi42 has updated the pull request. You must reimport the pull request before landing.

ajkr
ajkr approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the approach is fine to land though began wondering if we really need fragment level checksum calculated differently from record level checksum.

db/log_reader.cc Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@cbi42 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cbi42 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cbi42 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbi42 @facebook-github-bot @ajkr