Remove prop types checking in ReactCompositeComponent #6824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| @@ -830,7 +794,7 @@ var ReactCompositeComponentMixin = { | |||
| // warning for DOM component props in this upgrade | |||
| nextProps = nextParentElement.props; | |||
| } else { | |||
| nextProps = this._processProps(nextParentElement.props); | |||
| nextProps = nextParentElement.props; | |||
| willReceive = true; | |||
| } | |||
There was a problem hiding this comment.
Can you simplify this to
nextProps = nextParentElement.props;
if (prevParentElement !== nextParentElement) {
willReceive = true;
}
now?
| false, | ||
| 'Failed Context Types: %s%s', | ||
| error.message, | ||
| addendum |
There was a problem hiding this comment.
Do you mind switching this to use getStackAddendumByID to show the stack? That can be a separate PR if you prefer.
|
It's not obvious to me whether the two methods can be easily combined because they behave a little differently with the addendum (and it would be nice to calculate the addendum only if there is a warning) but if you see a way to clean them up let's do that in a follow-up PR. |
|
After fixing the inline comments, feel free to merge. |
|
@keyanzhang updated the pull request. |
This was referenced May 23, 2016
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
Remove prop types checking in ReactCompositeComponent (cherry picked from commit c136369)
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
Remove prop types checking in ReactCompositeComponent (cherry picked from commit c136369)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #6791. I renamed
_checkPropTypes()to_checkContextTypes()since it only checks context types for now.Moreover, now
ReactElementValidator'scheckPropTypes()andReactCompositeComponent's_checkContextTypes()are pretty much the same and we can merge them. Should I create a separate PR to refactor them or just change them here? @spicyj