Rename host-y things to be "host" not "native" #6754
Conversation
sophiebits
force-pushed
the
native-to-host
branch
from
784f261
to
18641bd
Compare
For clarity. I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils.
sophiebits
force-pushed
the
native-to-host
branch
from
18641bd
to
dc6b80f
Compare
|
While you're at it. rootNodeID/tag/domID/nodeHandle are a bit overloaded and unused on composite component. :) It is possible something might be used by the devtools/RN still not sure. I think these are mostly isolated now. |
|
Maybe another time. :) |
ghost
added
the
Tracking the changes in facebook/react#6754
Tracking the changes in facebook/react#6754
|
Do we need to make any changes to RN or anything else for this? I know ReactART needs 1 change but want to make sure there's nothing else. This is likely to go into a 15.y.0 (mostly for cherry-picking ease). |
|
There's two uses of .getNativeNode in RN but I think that's it. If we merge #6775 then we don't strictly need to update React ART now. |
|
So if we took this into 15.1 but RN cuts RC tomorrow, then we would be break them. But if we also take #6775 as is (with the fallback for the old getNativeNode method) then this would be safe without fixing RN now? |
|
No, RN calls getNativeNode in one place (whereas React ART only defines it for React to call). Basically we need to update that RN code when we land the next React update to RN that includes this commit. |
|
Ugh. Debug tools and their dependencies on internals... sigh. We need that public debug API. |
For clarity. I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils. (cherry picked from commit ba9b985)
|
This PR breaks |
|
@pke I left a comment about this in adambbecker/react-style-transition-group#1 (comment). |
For clarity. I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils. (cherry picked from commit ba9b985)
For clarity.
I left "native event" as-is because there's a lot of it, it's not particularly ambiguous, and SimulateNative/nativeTouchData are public API in ReactTestUtils.