consistent owner for stateless component

[yiminghe]

component should not have owner for both create and update lifecycle when in production.(not consistent will cause ref function call)

react/src/renderers/shared/reconciler/ReactRef.js

Line 65 in dc6fc8c

nextElement._owner !== prevElement._owner ||

[jimfb]

(not consistent will have a side effect for ref call)

What side effect? How is the code change related to the new unit test? (they look orthogonal at first glance)

[yiminghe]

you can run the tc. __dev__=true will call ref function once, __dev__=false will call ref function three times

if __dev__ = false

stateless component's element will not have owner when create:

react/src/renderers/shared/reconciler/ReactCompositeComponent.js

Line 309 in ae56910

if (__DEV__) {

stateless component's element will have owner when update:

react/src/renderers/shared/reconciler/ReactCompositeComponent.js

Line 903 in ae56910

ReactCurrentOwner.current = this;

so will trigger ref change:

react//src/renderers/shared/reconciler/ReactRef.js

Line 65 in ae56910

nextElement._owner !== prevElement._owner ||

[facebook-github-bot]

@yiminghe updated the pull request.

[yiminghe]

may related to

#6194

#6362

[facebook-github-bot]

@yiminghe updated the pull request.

[yiminghe]

ping @jimfb . better to keep the same behaviour in dev and production environment(except warning message).

[zpao]

cc @gaearon (seems related to #6362)

[gaearon]

Hmm. I don’t think #6362 is related per se.
The code that #6362 removed looked like this already:

-      if (__DEV__) {
-        ReactCurrentOwner.current = this;
-        try {
-          inst = new Component(publicProps, publicContext, ReactUpdateQueue);
-        } finally {
-          ReactCurrentOwner.current = null;
-        }
-      } else {
-        inst = new Component(publicProps, publicContext, ReactUpdateQueue);
-      }

[yiminghe]

@gaearon can you run the above tc on current master

[yiminghe]

@gaearon @spicyj can you take a look and fix this? One of my library(rc-form) relies ref to keep track of component destruction:

<Select {...controlProps}/>

https://github.com/react-component/form/blob/2b9ca198107011346735141ba39bc9636f5d7c58/src/createBaseForm.jsx#L342

This bug makes our app using stateless function component works fine during development and fails on production.

[ghost]

@yiminghe updated the pull request.

[sophiebits]

I guess this fix is correct. The logic here is very confusing though and I don't know what we can do to avoid bugs in the future. ReactRef should also not check the owner for function refs because there is no reason to, so I amended your commit to check that too and merged as b11540c.

[testones]

[zpao]

I missed this since it was closed and pushed separately. I'll get it into the next release.

[germangp088]

How i can validate a group of checkboxes?