[ci] Add yarn_test_build job to gh actions #30072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 9cd55d391a57a0254dc07c0982047005a89a2390 Pull Request resolved: #30072
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: e6783e7...cd878f1 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 2329f4cb6c03b89e4621fb5141c79695301b6b8e Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 6df35817371d0d3acf173227d0ac9e377543aa34 Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 642200ae95d8bc9009d08f495f1391950054be8c Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: c1bf83b54925954be64274bac3595acbb68f0d23 Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 8fba65fbc40ca07fc629d39adfb487d37e0b4244 Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: a8c594d753f454dd0695a1f8028e0a635fb1bc01 Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: a69f045720f4fe61ead4069ffdfb700288d630c9 Pull Request resolved: #30072
poteto
added a commit
to poteto/react
that referenced
this pull request
Jul 10, 2024
ghstack-source-id: 2588f3588f399f332225b353e67efa3816587401 Pull Request resolved: facebook#30072
poteto
added a commit
that referenced
this pull request
Jul 11, 2024
ghstack-source-id: 2588f3588f399f332225b353e67efa3816587401 Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jul 11, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jul 11, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jul 11, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd Pull Request resolved: #30072
poteto
added a commit
that referenced
this pull request
Jul 12, 2024
ghstack-source-id: 8431d588e7c2846d146c513599e668a7aac800bd Pull Request resolved: #30072
poteto
commented
Jul 12, 2024
Comment on lines
+61
to
+90
| test_params: [ | ||
| # Intentionally passing these as strings instead of creating a | ||
| # separate parameter per CLI argument, since it's easier to | ||
| # control/see which combinations we want to run. | ||
| -r=stable --env=development, | ||
| -r=stable --env=production, | ||
| -r=experimental --env=development, | ||
| -r=experimental --env=production, | ||
|
|
||
| # Dev Tools | ||
| --project=devtools -r=experimental, | ||
|
|
||
| # TODO: Update test config to support www build tests | ||
| # - "-r=www-classic --env=development --variant=false" | ||
| # - "-r=www-classic --env=production --variant=false" | ||
| # - "-r=www-classic --env=development --variant=true" | ||
| # - "-r=www-classic --env=production --variant=true" | ||
| # - "-r=www-modern --env=development --variant=false" | ||
| # - "-r=www-modern --env=production --variant=false" | ||
| # - "-r=www-modern --env=development --variant=true" | ||
| # - "-r=www-modern --env=production --variant=true" | ||
|
|
||
| # TODO: Update test config to support xplat build tests | ||
| # - "-r=xplat --env=development --variant=false" | ||
| # - "-r=xplat --env=development --variant=true" | ||
| # - "-r=xplat --env=production --variant=false" | ||
| # - "-r=xplat --env=production --variant=true" | ||
|
|
||
| # TODO: Test more persistent configurations? | ||
| ] |
There was a problem hiding this comment.
copied from circleci config
jackpope
approved these changes
Jul 12, 2024
| merge-multiple: true | ||
| - name: Display structure of build | ||
| run: ls -R build | ||
| - run: yarn test --build ${{ matrix.test_params }} --ci=github |
There was a problem hiding this comment.
Does this parallelize by default? If not, should we?
There was a problem hiding this comment.
It is parallelized, it uses the matrix defined above and creates a CI worker for each value in the matrix
poteto
added a commit
that referenced
this pull request
Jul 12, 2024
ghstack-source-id: 5cff9778611acb747c05b9d353bd1af3b11e7d7a Pull Request resolved: #30072
felixshiftellecon
added a commit
to felixshiftellecon/react
that referenced
this pull request
Jul 24, 2024
ghstack-source-id: 5cff9778611acb747c05b9d353bd1af3b11e7d7a Pull Request resolved: facebook#30072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):