Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] "Missing React element for debugID" triggered by ReactDOMServer.renderToStaticMarkup #7190

Closed
pvande opened this issue Jul 5, 2016 · 4 comments
Closed

[Bug] "Missing React element for debugID" triggered by ReactDOMServer.renderToStaticMarkup #7190

pvande opened this issue Jul 5, 2016 · 4 comments
Labels
Resolution: Duplicate

Comments

@pvande
Copy link

pvande commented Jul 5, 2016

As of React v15.2.0, the provided fiddle is throwing the "Missing React element for debugID" warning, which has been described as an internal (i.e. not user-facing) React warning.

https://jsfiddle.net/s4c36s0n/

This warning was not present in React v15.1.0.

(I make no claim that this is a sane usage pattern, only that it exists in real-world components and that it's an unexpected failure case.)
@gaearon
Copy link
Collaborator

gaearon commented Jul 5, 2016

Thanks! Yes, this is a duplicate of #7187.

@gaearon gaearon closed this as completed Jul 5, 2016
@gaearon gaearon mentioned this issue Jul 5, 2016
Closed
@pvande
Copy link
Author

pvande commented Jul 5, 2016

@gaearon Wasn't sure if you wanted separate issues for different causes or if you just wanted a single issue tracking the symptom. Cheers!

@gaearon
Copy link
Collaborator

gaearon commented Jul 5, 2016

Yea, thanks for filing! (The issue is the same but it’s good to have several test cases.)

@gaearon gaearon mentioned this issue Jul 5, 2016
Merged
gaearon added a commit that referenced this issue Jul 5, 2016
@gaearon
Pass shouldHaveDebugID flag to instantiateComponent (#7193)
d2ff462 
* Add failing tests for #7187 and #7190

* Pass shouldHaveDebugID flag to instantiateComponent

This allows us to remove a hack that was added in #6770 and caused #7187 and #7190.

* Move logic for choosing whether to use debugID outside instantiate
@gaearon
Copy link
Collaborator

gaearon commented Jul 5, 2016

Fixed by #7193.

zpao pushed a commit that referenced this issue Jul 8, 2016
@gaearon @zpao
Pass shouldHaveDebugID flag to instantiateComponent (#7193)
720ce5a 
* Add failing tests for #7187 and #7190

* Pass shouldHaveDebugID flag to instantiateComponent

This allows us to remove a hack that was added in #6770 and caused #7187 and #7190.

* Move logic for choosing whether to use debugID outside instantiate

(cherry picked from commit d2ff462)
usmanajmal pushed a commit to usmanajmal/react that referenced this issue Jul 11, 2016
@gaearon @usmanajmal
Pass shouldHaveDebugID flag to instantiateComponent (facebook#7193)
00b1ea8 
* Add failing tests for facebook#7187 and facebook#7190

* Pass shouldHaveDebugID flag to instantiateComponent

This allows us to remove a hack that was added in facebook#6770 and caused facebook#7187 and facebook#7190.

* Move logic for choosing whether to use debugID outside instantiate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pvande @gaearon