Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU 4.4.1 not correctly identified #124

Closed
killes opened this issue Jul 17, 2010 · 1 comment
Closed

ICU 4.4.1 not correctly identified #124

killes opened this issue Jul 17, 2010 · 1 comment

Comments

@killes
Copy link

killes commented Jul 17, 2010

apparently, FindICU.cmake does look into a file named uversion.h to find the version, but that info got moved to uvernum.h. If you replace uversion.h by uvernum.h in FindICU.make, the version is correctly identified.
@scottmac
Copy link
Contributor

Fixed in 5fc3489

h4ck3rm1k3 pushed a commit to h4ck3rm1k3/hhvm that referenced this issue Sep 13, 2011
Fix Issue facebook#124, ICU header file moved in ICU 4.4.
5fc3489
@andrisi andrisi mentioned this issue Oct 16, 2014
Closed
facebook-github-bot pushed a commit that referenced this issue Jan 27, 2023
@simuthus-fb @facebook-github-bot
Disable FBOSS OSS tests in on-diff jobs (#124)
28ef68b 
Summary:
X-link: facebook/fboss#124

X-link: facebookincubator/reindeer#6

X-link: facebook/sapling#497

X-link: facebook/mvfst#284

X-link: facebook/wangle#212

X-link: facebookincubator/velox#3785

X-link: facebookexperimental/rust-shed#37

Pull Request resolved: #9317

X-link: facebookexperimental/edencommon#6

X-link: facebookincubator/hsthrift#108

X-link: facebook/proxygen#436

X-link: facebookincubator/katran#183

X-link: facebook/openr#143

X-link: facebook/fbthrift#536

X-link: facebook/fb303#33

X-link: facebook/folly#1924

FBOSS OSS on-diff job is failing due to random test failures.

Disabling the tests for now to avoid build breakages.

Reviewed By: shri-khare

Differential Revision: D42550176

fbshipit-source-id: a40a4d39c2176e4a201f6c49c6e7837c4c7c90e5
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottmac @killes