Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing native dependencies on packaged artifacts #2748

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Motivation (required)

Latest versions of Fresco have missing .so files due to a race condition on Gradle tasks.
I'm imposing a task dependencies on ndk_build_* steps and preBuild steps to prevent this.

Fixes #2722
Fixes #2747

Test Plan (required)

I've tested this against ./gradlew publishToMavenLocal upon clean build.
Here the output:

$ unzip -l ~/.m2/repository/com/facebook/fresco/nativeimagetranscoder/3.1.1/nativeimagetranscoder-3.1.1.aar
Archive:  /Users/ncor/.m2/repository/com/facebook/fresco/nativeimagetranscoder/3.1.1/nativeimagetranscoder-3.1.1.aar
  Length      Date    Time    Name
---------  ---------- -----   ----
     7297  02-01-1980 00:00   R.txt
      216  02-01-1980 00:00   AndroidManifest.xml
     6034  02-01-1980 00:00   classes.jar
      121  02-01-1980 00:00   META-INF/com/android/build/gradle/aar-metadata.properties
        0  02-01-1980 00:00   jni/
        0  02-01-1980 00:00   jni/arm64-v8a/
   475392  02-01-1980 00:00   jni/arm64-v8a/libnative-imagetranscoder.so
        0  02-01-1980 00:00   jni/armeabi-v7a/
   271736  02-01-1980 00:00   jni/armeabi-v7a/libnative-imagetranscoder.so
        0  02-01-1980 00:00   jni/x86/
   557648  02-01-1980 00:00   jni/x86/libnative-imagetranscoder.so
        0  02-01-1980 00:00   jni/x86_64/
   621000  02-01-1980 00:00   jni/x86_64/libnative-imagetranscoder.so
---------                     -------
  1939444                     13 files

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in ce4d35e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants