Skip to content

Commit

Permalink
Update parameter name to make it clear it's animated strategy buffer
Browse files Browse the repository at this point in the history
Differential Revision: D58347267

fbshipit-source-id: cdb0e0c9dca47add229c6c4d3bab9dff13a8cccc
  • Loading branch information
Pawel Koltuniuk authored and facebook-github-bot committed Jun 11, 2024
1 parent f1fbb59 commit da28826
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ImagePipelineExperiments private constructor(builder: Builder) {
val useDownsamplingRatioForResizing: Boolean
val useBitmapPrepareToDraw: Boolean
val useBalancedAnimationStrategy: Boolean
val balancedStrategyBufferLengthMilliseconds: Int
val animationStrategyBufferLengthMilliseconds: Int
val bitmapPrepareToDrawMinSizeBytes: Int
val bitmapPrepareToDrawMaxSizeBytes: Int
val bitmapPrepareToDrawForPrefetch: Boolean
Expand Down Expand Up @@ -85,7 +85,7 @@ class ImagePipelineExperiments private constructor(builder: Builder) {
@JvmField var useDownsamplingRatioForResizing = false
@JvmField var useBitmapPrepareToDraw = false
@JvmField var useBalancedAnimationStrategy = false
@JvmField var balancedStrategyBufferLengthMilliseconds = 1000
@JvmField var animationStrategyBufferLengthMilliseconds = 1000
@JvmField var bitmapPrepareToDrawMinSizeBytes = 0
@JvmField var bitmapPrepareToDrawMaxSizeBytes = 0

Expand Down Expand Up @@ -220,11 +220,12 @@ class ImagePipelineExperiments private constructor(builder: Builder) {
this.useBalancedAnimationStrategy = useBalancedAnimationStrategy
}

/** The balance strategy buffer length for single image */
fun setBalancedStrategyBufferLengthMilliseconds(balancedStrategyBufferLengthMilliseconds: Int) =
asBuilder {
this.balancedStrategyBufferLengthMilliseconds = balancedStrategyBufferLengthMilliseconds
}
/** The balanced animation strategy buffer length for single animation */
fun setAnimationStrategyBufferLengthMilliseconds(
animationStrategyBufferLengthMilliseconds: Int
) = asBuilder {
this.animationStrategyBufferLengthMilliseconds = animationStrategyBufferLengthMilliseconds
}

/**
* Sets the maximum bitmap size use to compute the downsampling value when decoding Jpeg images.
Expand Down Expand Up @@ -415,7 +416,7 @@ class ImagePipelineExperiments private constructor(builder: Builder) {
useDownsamplingRatioForResizing = builder.useDownsamplingRatioForResizing
useBitmapPrepareToDraw = builder.useBitmapPrepareToDraw
useBalancedAnimationStrategy = builder.useBalancedAnimationStrategy
balancedStrategyBufferLengthMilliseconds = builder.balancedStrategyBufferLengthMilliseconds
animationStrategyBufferLengthMilliseconds = builder.animationStrategyBufferLengthMilliseconds
bitmapPrepareToDrawMinSizeBytes = builder.bitmapPrepareToDrawMinSizeBytes
bitmapPrepareToDrawMaxSizeBytes = builder.bitmapPrepareToDrawMaxSizeBytes
bitmapPrepareToDrawForPrefetch = builder.bitmapPrepareToDrawForPrefetch
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ private AnimatedFactory getAnimatedFactory() {
mConfig.getExperiments().getDownscaleFrameToDrawableDimensions(),
mConfig.getExperiments().getUseBalancedAnimationStrategy(),
mConfig.getExperiments().getAnimationRenderFpsLimit(),
mConfig.getExperiments().getBalancedStrategyBufferLengthMilliseconds(),
mConfig.getExperiments().getAnimationStrategyBufferLengthMilliseconds(),
mConfig.getExecutorServiceForAnimatedImages());
}
return mAnimatedFactory;
Expand Down

0 comments on commit da28826

Please sign in to comment.